Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: starter rag example didnt contain connection from rag to template #2930

Merged
merged 2 commits into from
Jul 24, 2024
Merged

bug: starter rag example didnt contain connection from rag to template #2930

merged 2 commits into from
Jul 24, 2024

Conversation

lucaseduoli
Copy link
Collaborator

  • fixed connection between rag and template
  • updated nodes

@lucaseduoli lucaseduoli self-assigned this Jul 24, 2024
@lucaseduoli lucaseduoli linked an issue Jul 24, 2024 that may be closed by this pull request
vector store RAG #2909
Closed
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 24, 2024
@dosubot dosubot bot added the bug Something isn't working label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 24 Jul 24 20:50 UTC

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 24, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) July 24, 2024 20:51
anovazzi1
anovazzi1 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaseduoli lucaseduoli merged commit ce7418a into main Jul 24, 2024
10 of 11 checks passed
@lucaseduoli lucaseduoli deleted the 2909-vector-store-rag branch July 24, 2024 20:52
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2930.dmtpw4p5recq1.amplifyapp.com

nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
@lucaseduoli @nicoloboschi
bug: starter rag example didnt contain connection from rag to template (
5738f30 
langflow-ai#2930)

* Changed starter example Vector Store RAG

* Formatted example

(cherry picked from commit ce7418a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

Assignees

@lucaseduoli lucaseduoli

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vector store RAG
2 participants
@lucaseduoli @anovazzi1