Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test to allow any errors checks #2926

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

Cristhianzl
Copy link
Collaborator

🐛 (generalBugs-shard-6.spec.ts): fix test assertion to check for error message length greater than 20 instead of 50 for improved accuracy

…r message length greater than 20 instead of 50 for improved accuracy
@Cristhianzl Cristhianzl self-assigned this Jul 24, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 24, 2024
@dosubot dosubot bot added the bug Something isn't working label Jul 24, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 24 Jul 24 18:09 UTC

@github-actions github-actions bot added test Changes to tests and removed bug Something isn't working labels Jul 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2926.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 24, 2024 18:12
@ogabrielluiz ogabrielluiz merged commit 544e763 into main Jul 24, 2024
12 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fixTestCC branch July 24, 2024 18:13
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
🐛 (generalBugs-shard-6.spec.ts): fix test assertion to check for error message length greater than 20 instead of 50 for improved accuracy

(cherry picked from commit 544e763)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. test Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants