Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate transactions to sql database #2915

Merged
merged 11 commits into from
Jul 26, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Jul 24, 2024

  • Use transactions table on sqldb instead of duckdb
  • Transactions are wrote best-effort async to avoid blocking hot path
  • Ensure migrations happen at the startup
  • Added file lock before acquiring duckdb connection to avoid concurrency errors
  • Fixed a bug whereas all transactions and built vertex are wiped out at every startup
  • Improved conccurreny in services

Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

Last Modified at 24 Jul 24 12:26 UTC

@github-actions github-actions bot added the enhancement New feature or request label Jul 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2915.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 25, 2024
@nicoloboschi nicoloboschi marked this pull request as ready for review July 25, 2024 16:26
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Jul 25, 2024
@ogabrielluiz ogabrielluiz self-requested a review July 25, 2024 18:58
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nicoloboschi

Thank you for this.

Just some minor comments and this should be good to go.

src/backend/base/langflow/graph/graph/base.py Outdated Show resolved Hide resolved
src/backend/base/langflow/graph/graph/base.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 26, 2024
@nicoloboschi nicoloboschi enabled auto-merge (squash) July 26, 2024 13:25
@nicoloboschi nicoloboschi merged commit 9ac861d into langflow-ai:main Jul 26, 2024
51 checks passed
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* feat: migrate transactions to sql database

* feat: migrate transactions to sql database

* feat: migrate transactions to sql database

* feat: migrate transactions to sql database

* feat: migrate transactions to sql database

* feat: migrate transactions to sql database

* [autofix.ci] apply automated fixes

* remove useless

* remove useless

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9ac861d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants