-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add useQuery to delete folder api requests #2901
Conversation
β¦interactable before performing actions to prevent flakiness
β¦ng of the component π (folders/index.tsx): Add use-delete-folders query to handle deletion of folders π (folders/use-delete-folders.ts): Create useDeleteFolders hook to handle deletion of folders π (mainPage/index.tsx): Import useDeleteFolders hook and implement handleDeleteFolder function to delete folders and show success/error messages
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 23 Jul 24 20:34 UTC |
π§ (mainPage/index.tsx): Remove import of use-delete-folder hook as it is no longer used
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tested local
* π (generalBugs-shard-5.spec.ts): fix test to wait for elements to be interactable before performing actions to prevent flakiness * β¨ (editFlowSettingsComponent): Add padding top class to improve styling of the component π (folders/index.tsx): Add use-delete-folders query to handle deletion of folders π (folders/use-delete-folders.ts): Create useDeleteFolders hook to handle deletion of folders π (mainPage/index.tsx): Import useDeleteFolders hook and implement handleDeleteFolder function to delete folders and show success/error messages * π§ (use-delete-folder.tsx): Remove unused file use-delete-folder.tsx π§ (mainPage/index.tsx): Remove import of use-delete-folder hook as it is no longer used (cherry picked from commit 18dfd9a)
β¨ (editFlowSettingsComponent): Add padding top class to improve styling of the component
π (folders/index.tsx): Add use-delete-folders query to handle deletion of folders
π (folders/use-delete-folders.ts): Create useDeleteFolders hook to handle deletion of folders
π (mainPage/index.tsx): Import useDeleteFolders hook and implement handleDeleteFolder function to delete folders and show success/error messages