Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add useQuery to delete folder api requests #2901

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

Cristhianzl
Copy link
Collaborator

✨ (editFlowSettingsComponent): Add padding top class to improve styling of the component
πŸ“ (folders/index.tsx): Add use-delete-folders query to handle deletion of folders
πŸ“ (folders/use-delete-folders.ts): Create useDeleteFolders hook to handle deletion of folders
πŸ“ (mainPage/index.tsx): Import useDeleteFolders hook and implement handleDeleteFolder function to delete folders and show success/error messages

…interactable before performing actions to prevent flakiness
…ng of the component

πŸ“ (folders/index.tsx): Add use-delete-folders query to handle deletion of folders

πŸ“ (folders/use-delete-folders.ts): Create useDeleteFolders hook to handle deletion of folders

πŸ“ (mainPage/index.tsx): Import useDeleteFolders hook and implement handleDeleteFolder function to delete folders and show success/error messages
@Cristhianzl Cristhianzl self-assigned this Jul 23, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 23, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored βœ… ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored βœ… ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ βœ…
Pull request does not introduce too many changes ❌ βœ…
Pull request has a valid title βœ… βœ…
Pull request has mentioned issues ❌ βœ…
Pull request has valid branch name ❌ βœ…
Pull request should have a non-empty body βœ… βœ…

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 23 Jul 24 20:34 UTC

@github-actions github-actions bot removed the enhancement New feature or request label Jul 23, 2024
πŸ”§ (mainPage/index.tsx): Remove import of use-delete-folder hook as it is no longer used
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jul 23, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 23, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2901.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested local

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 23, 2024
@Cristhianzl Cristhianzl merged commit 18dfd9a into main Jul 23, 2024
14 checks passed
@Cristhianzl Cristhianzl deleted the refactor/deleteFolders branch July 23, 2024 22:28
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* πŸ› (generalBugs-shard-5.spec.ts): fix test to wait for elements to be interactable before performing actions to prevent flakiness

* ✨ (editFlowSettingsComponent): Add padding top class to improve styling of the component

πŸ“ (folders/index.tsx): Add use-delete-folders query to handle deletion of folders

πŸ“ (folders/use-delete-folders.ts): Create useDeleteFolders hook to handle deletion of folders

πŸ“ (mainPage/index.tsx): Import useDeleteFolders hook and implement handleDeleteFolder function to delete folders and show success/error messages

* πŸ”§ (use-delete-folder.tsx): Remove unused file use-delete-folder.tsx
πŸ”§ (mainPage/index.tsx): Remove import of use-delete-folder hook as it is no longer used

(cherry picked from commit 18dfd9a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants