bugfix: add returning promises on interceptor errors + tests #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interactable before performing actions to prevent flakiness
…roperly 📝 (codeAreaModal/index.tsx): add data-testid attribute to title element for testing purposes ✨ (generalBugs-shard-6.spec.ts): add end-to-end test for error handling in Code Modal
dosubot
bot
added
size:M
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 23 Jul 24 15:48 UTC |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…larity and grammar
italojohnny
approved these changes
Jul 23, 2024
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
…w-ai#2896) * 🐛 (generalBugs-shard-5.spec.ts): fix test to wait for elements to be interactable before performing actions to prevent flakiness * 📝 (API/api.tsx): return error in promise rejection to handle errors properly 📝 (codeAreaModal/index.tsx): add data-testid attribute to title element for testing purposes ✨ (generalBugs-shard-6.spec.ts): add end-to-end test for error handling in Code Modal * 📝 (generalBugs-shard-6.spec.ts): update test description for better clarity and grammar (cherry picked from commit c83006e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix error that interceptor is not throwing error as espected:
#2895
📝 (API/api.tsx): return error in promise rejection to handle errors properly
📝 (codeAreaModal/index.tsx): add data-testid attribute to title element for testing purposes
✨ (generalBugs-shard-6.spec.ts): add end-to-end test for error handling in Code Modal