Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: authentication logic and move isAdmin to zustand store #2888

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request refactors the authentication logic by removing the isAdmin variable from the context and moving it to the zustand store. This improves the separation of concerns and makes the code more modular and maintainable.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Jul 23, 2024
@anovazzi1 anovazzi1 requested a review from Cristhianzl July 23, 2024 11:59
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 23 Jul 24 12:00 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jul 23, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2888.dmtpw4p5recq1.amplifyapp.com

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 23, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) July 23, 2024 14:55
@anovazzi1 anovazzi1 merged commit b7bc36d into main Jul 23, 2024
30 checks passed
@anovazzi1 anovazzi1 deleted the isAdminRefactor branch July 23, 2024 14:59
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
…gflow-ai#2888)

* refactor: remove isAuthenticated from context and move it to zustand store

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
(cherry picked from commit b7bc36d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants