-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Add function to check broken edges #2882
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 22 Jul 24 22:41 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo! Looking good. Just some comments
src/frontend/src/utils/utils.ts
Outdated
source: string; | ||
target: string; | ||
}) { | ||
return `${source} -> ${target}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be something like ChatInput | Message -> Sender Name | ChatOutput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this will be too verbose? the edge is already deleted, i can't see how this change helps the user to identify which edge was deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They might not remember which edge was put where.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can give more info so that the user does not have to think when fixing the problem, we should do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure,I will update
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
* chore: create new function to check broken edges * enhancement: add edges check when a new flow is added * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * refactor: update BROKEN_EDGES_WARNING message to use "connections" instead of "edges" * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * update function name * refactor: improve error handling in detectBrokenEdgesEdges function * remove console.log Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> (cherry picked from commit 4c3ec04)
This pull request adds a new function to check for broken edges in the code. The function detects if the source or target nodes or handles no longer exist and displays an error message with the list of broken edges.