Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shortcuts settings page button spacing #2859

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix: shortcuts settings page button spacing #2859

merged 3 commits into from
Jul 22, 2024

Conversation

igorrCarvalho
Copy link
Contributor

This PR addresses an issue with the button spacing on the shortcuts settings page.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working javascript Pull requests that update Javascript code labels Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 22 Jul 24 00:25 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 22, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2859.dmtpw4p5recq1.amplifyapp.com

anovazzi1
anovazzi1 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2024
@Cristhianzl Cristhianzl merged commit 9ecf101 into main Jul 22, 2024
29 checks passed
@Cristhianzl Cristhianzl deleted the fix/buttonSpacing branch July 22, 2024 21:09
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
@igorrCarvalho @nicoloboschi
fix: shortcuts settings page button spacing (langflow-ai#2859)
105f97a 
Co-authored-by: anovazzi1 <[email protected]>
Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
(cherry picked from commit 9ecf101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorrCarvalho @anovazzi1 @Cristhianzl