fix(get-python-api-code):fixing errors in a file uploading flow, as in issue #2799 #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
3 tasks
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
anovazzi1
force-pushed
the
fix/python_api_code
branch
from
8a86adc
to
91006f1
Compare
ogabrielluiz
requested changes
Jul 23, 2024
| @@ -54,7 +54,7 @@ def upload_file(file_path: str, host: str, flow_id: str, components: list[str], | |||
| if response["file_path"]: | |||
| for component in components: | |||
| if isinstance(component, str): | |||
| tweaks[component] = {"file_path": response["file_path"]} | |||
| tweaks[component] = {"path": response["file_path"]} | |||
There was a problem hiding this comment.
Hey @vertgo
file_path is the generic field reserved for paths in the Langflow's storage system. All file fields use this same attribute and path is not always used.
There was a problem hiding this comment.
Try reverting this and see if your tests still work. If not, then maybe keep path and we fix it later.
There was a problem hiding this comment.
if some components use file_path and others use path then we can set them both in tweaks, but i had changed it because it wasn't working (this was v.1.0.9, so that was a while ago)
ogabrielluiz
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the code to allow a return value of 201
properly parse the components argument
handle the case of having no endpoint name to default to flow_id
changing the tweak value of path instead of file_path (correct for the file component)