Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor CI workflow conditions to run only when PR is approved #2805

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request refactors the CI workflow by adding a new job called "check-reviews" and updating the "path-filter" job to depend on the output of the "check-reviews" job. This improves the readability and maintainability of the workflow.

@ogabrielluiz ogabrielluiz requested a review from italojohnny July 18, 2024 17:49
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 18, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 18 Jul 24 17:49 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2805.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 18, 2024
…ion to check for 'lgtm' label before running the job
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 18, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 18, 2024 19:19
@ogabrielluiz ogabrielluiz merged commit 6ffe579 into main Jul 18, 2024
8 of 9 checks passed
@ogabrielluiz ogabrielluiz deleted the ci/improvecond branch July 18, 2024 19:19
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
…angflow-ai#2805)

* refactor: add check-reviews job to ci.yml

* refactor(ci.yml): update path-filter condition to depend on the output of check-reviews job for improved readability and maintainability

* chore(ci.yml): remove check-reviews job and update path-filter condition to check for 'lgtm' label before running the job

(cherry picked from commit 6ffe579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants