Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce helper functions for dynamic tracer import #2778

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request includes the following changes:

  • Removed an unused import in langwatch.py.

  • Introduced helper functions _get_langsmith_tracer and _get_langwatch_tracer in tracing/service.py to dynamically import tracers.

These changes improve the development and testing experience and enhance the flexibility of tracer imports in the tracing service.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jul 17, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 17 Jul 24 23:54 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 17, 2024
@ogabrielluiz ogabrielluiz merged commit 6d291c8 into main Jul 17, 2024
4 of 5 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/version branch July 17, 2024 23:55
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
…ai#2778)

* fix: remove unused import in langwatch.py

* feat(tracing/service.py): introduce helper functions _get_langsmith_tracer and _get_langwatch_tracer to dynamically import tracers

(cherry picked from commit 6d291c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant