Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logs on component output #2740

Merged
merged 15 commits into from
Jul 16, 2024
Merged

feat: logs on component output #2740

merged 15 commits into from
Jul 16, 2024

Conversation

lucaseduoli
Copy link
Collaborator

  • Added Logs page on the Component Output, to show various logs about the component's build process.

image

@lucaseduoli lucaseduoli requested a review from ogabrielluiz July 16, 2024 19:42
@lucaseduoli lucaseduoli self-assigned this Jul 16, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

Last Modified at 16 Jul 24 19:43 UTC

@github-actions github-actions bot added the enhancement New feature or request label Jul 16, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2740.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli marked this pull request as ready for review July 16, 2024 21:12
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 16, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Jul 16, 2024
The code changes include adding a new attribute `_output_logs` to the `CustomComponent` class. This attribute is a dictionary that stores logs related to output values. This change is necessary to enhance the logging functionality of the component.

Note: Please remove any meta information such as issue references, tags, or author names from the commit message.
This commit modifies the `BaseCrewComponent` class in the `crew.py` file. It adds serialization of messages using the `to_json()` method to avoid circular reference issues. The `_messages_dict` dictionary is serialized by converting each message object to JSON format. This change enhances the functionality of the component and improves the logging process.

Note: Please remove any meta information such as issue references, tags, or author names from the commit message.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 16, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 16, 2024 22:20
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 16, 2024
@ogabrielluiz ogabrielluiz force-pushed the feature/logs_component branch from abf4df8 to dacda13 Compare July 16, 2024 22:23
@ogabrielluiz ogabrielluiz merged commit 0897ee5 into main Jul 16, 2024
44 checks passed
@ogabrielluiz ogabrielluiz deleted the feature/logs_component branch July 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants