feat: new Vectara RAG Component #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 16 Jul 24 17:26 UTC |
|
Hey @david-oplatka Thanks for the PR. I've changed the base to |
ogabrielluiz
force-pushed
the
vectara_update
branch
from
4b649d2
to
7e0c5e4
Compare
|
Thanks @ogabrielluiz - anything else needed? |
ogabrielluiz
approved these changes
Jul 26, 2024
|
Hey @ofermend I've updated the component. If it is working as intended by @david-oplatka. We can merge it. |
|
SG. Let's merge then - thanks! |
ogabrielluiz
changed the title
github-actions
bot
added
enhancement
Update the filter parameter in the VectaraRagComponent class to use the correct variable name 'self.filter' instead of 'filter'. This ensures that the correct filter value is passed to the VectaraQueryConfig object.
Add a condition to the `set_cache_coro` function call in the `Graph` class. The condition checks if the `cache` variable is true and the `flow_id` is not empty before calling the function. This ensures that the cache is set only when both conditions are met, improving the efficiency of the code.
ogabrielluiz
force-pushed
the
vectara_update
branch
from
72467ac
to
544433c
Compare
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
* First implementation of LangWatch tracer * Remove dependency from backend base internal and add langwatch docs * Bump langwatch to v0.1.4 * Fix missing log parameter on method * Move docs to the right folder * chore: update lock * Add Vectara RAG component and docs * [autofix.ci] apply automated fixes * refactor: update VectaraRAG component to the new component standard * fix: update VectaraRagComponent filter parameter Update the filter parameter in the VectaraRagComponent class to use the correct variable name 'self.filter' instead of 'filter'. This ensures that the correct filter value is passed to the VectaraQueryConfig object. * fix: add condition to set_cache_coro in Graph class Add a condition to the `set_cache_coro` function call in the `Graph` class. The condition checks if the `cache` variable is true and the `flow_id` is not empty before calling the function. This ensures that the cache is set only when both conditions are met, improving the efficiency of the code. --------- Co-authored-by: Rogério Chaves <[email protected]> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 469625c)
|
damn good !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component implements the full Vectara RAG pipeline. New changes: