Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make error messages more generic #2726

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

italojohnny
Copy link
Member

When attempting to import a non-existent library, the editor reports an import error, suggests a correction, and is supposed to display a traceback. However, the suggested correction is nonsensical, and there is no traceback information available to be returned.

20240716110028_825x709

This PR adjusts the error message to be more generic and removes the correction suggestion and traceback data.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 16, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 16 Jul 24 14:10 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2726.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 16, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 16, 2024 14:21
@ogabrielluiz ogabrielluiz merged commit a534ac7 into main Jul 16, 2024
47 checks passed
@ogabrielluiz ogabrielluiz deleted the chore/generic_error_message branch July 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants