Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update chat components to make them backwards compatible #2725

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Restores store_message method so chat components stay backwards compatible and rename inputs so they don't collide with the method's name.

@ogabrielluiz ogabrielluiz requested a review from italojohnny July 16, 2024 13:48
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Jul 16, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 16 Jul 24 13:49 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2725.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 16, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 16, 2024 14:06
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 16, 2024
@ogabrielluiz ogabrielluiz merged commit 7d3fac6 into main Jul 16, 2024
49 checks passed
@ogabrielluiz ogabrielluiz deleted the fix_chat_components branch July 16, 2024 14:19
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants