-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: vertex instantiation #2703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically being deployed by Amplify Hosting (learn more). |
italojohnny
force-pushed
the
refactor/vertex_instantiation
branch
2 times, most recently
from
July 19, 2024 07:24
704fcd5
to
fde59bc
Compare
italojohnny
force-pushed
the
refactor/vertex_instantiation
branch
3 times, most recently
from
July 23, 2024 17:17
45d4e90
to
b7d0144
Compare
italojohnny
changed the title
Refactor/vertex instantiation
refactor: vertex instantiation
Jul 24, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
python
Pull requests that update Python code
labels
Jul 24, 2024
github-actions
bot
added
refactor
Maintenance tasks and housekeeping
and removed
refactor
Maintenance tasks and housekeeping
labels
Jul 24, 2024
ogabrielluiz
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
italojohnny
force-pushed
the
refactor/vertex_instantiation
branch
from
July 24, 2024 16:50
b7d0144
to
779d6f0
Compare
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 30, 2024
* style: handle whitespaces around colons * refactor: split a func into two * refactor: update code to use newly created funcs * refactor: merge code of one func into another * refactor: rename func * refactor: extract code segment to parent func * refactor: extract code segment to parent func * refactor: rename func * refactor: rename object * refactor: extract code segment into a new func * feat: add condition to determine how the vertex is built * fix: modify component initialization call (cherry picked from commit e318694)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the instantiation of vertices, allowing vertices to optionally contain a reference to a component without breaking the existing behavior of the code.