Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: vertex instantiation #2703

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Conversation

italojohnny
Copy link
Member

@italojohnny italojohnny commented Jul 15, 2024

This PR refactors the instantiation of vertices, allowing vertices to optionally contain a reference to a component without breaking the existing behavior of the code.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2703.dmtpw4p5recq1.amplifyapp.com

@italojohnny italojohnny force-pushed the refactor/vertex_instantiation branch 2 times, most recently from 704fcd5 to fde59bc Compare July 19, 2024 07:24
@italojohnny italojohnny force-pushed the refactor/vertex_instantiation branch 3 times, most recently from 45d4e90 to b7d0144 Compare July 23, 2024 17:17
@italojohnny italojohnny changed the title Refactor/vertex instantiation refactor: vertex instantiation Jul 24, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jul 24, 2024
@italojohnny italojohnny marked this pull request as ready for review July 24, 2024 16:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. python Pull requests that update Python code labels Jul 24, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jul 24, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@italojohnny italojohnny force-pushed the refactor/vertex_instantiation branch from b7d0144 to 779d6f0 Compare July 24, 2024 16:50
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 24, 2024 17:30
@ogabrielluiz ogabrielluiz merged commit e318694 into main Jul 24, 2024
49 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor/vertex_instantiation branch July 24, 2024 18:28
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* style: handle whitespaces around colons

* refactor: split a func into two

* refactor: update code to use newly created funcs

* refactor: merge code of one func into another

* refactor: rename func

* refactor: extract code segment to parent func

* refactor: extract code segment to parent func

* refactor: rename func

* refactor: rename object

* refactor: extract code segment into a new func

* feat: add condition to determine how the vertex is built

* fix: modify component initialization call

(cherry picked from commit e318694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants