Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add payload validation, update Simple API Test fixture, run tests #2664

Merged
merged 11 commits into from
Jul 12, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request updates the Simple API Test fixture in the conftest.py file and modifies the test endpoints in the test_endpoints.py file. The changes ensure that the tests use the correct API test configuration and reflect the recent updates made to the codebase.

Update test assertions for successful runs with input types

The test assertions in the test_endpoints.py file have been updated to reflect the changes in the code. The assertions now correctly check the number of outputs and the values of the input_value for different input types. This ensures that the tests accurately verify the behavior of the API endpoints.

Remove api_key_required fixture from run endpoint tests

The api_key_required fixture has been removed from the run endpoint tests. This simplifies the test setup and ensures that the tests focus on the specific functionality being tested.

Update input_value default value in SimplifiedAPIRequest schema

The default value for the input_value field in the SimplifiedAPIRequest schema has been changed from an empty string to None. This ensures that the default value accurately represents the absence of an input value.

Add InvalidChatInputException to exceptions/api.py

This commit adds the InvalidChatInputException class to the exceptions/api.py file. This exception is raised when there is an invalid chat input value or tweak combination in the simplified run flow.

Validate input value and tweaks in simplified run flow

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 12, 2024
@ogabrielluiz ogabrielluiz requested a review from anovazzi1 July 12, 2024 16:49
@dosubot dosubot bot added the python Pull requests that update Python code label Jul 12, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 12, 2024 16:52
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2024
@anovazzi1 anovazzi1 force-pushed the add_more_api_tests branch from 7f70384 to 4f1415e Compare July 12, 2024 16:53
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 12 Jul 24 16:56 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 12, 2024
This commit updates the Simple API Test fixture in the conftest.py file and modifies the test endpoints in the test_endpoints.py file. The changes ensure that the tests use the correct API test configuration and reflect the recent updates made to the codebase.
The test assertions in the test_endpoints.py file have been updated to reflect the changes in the code. The assertions now correctly check the number of outputs and the values of the input_value for different input types. This ensures that the tests accurately verify the behavior of the API endpoints.
The default value for the `input_value` field in the `SimplifiedAPIRequest` schema has been changed from an empty string to `None`. This ensures that the default value accurately represents the absence of an input value.
This commit adds validation for the input value and tweaks in the simplified_run_flow function. If both the input value and tweaks are provided, it checks for conflicts and raises an InvalidChatInputException if necessary. This ensures that the input value and tweaks are handled correctly and prevents conflicts between them.

Refactor the code in simplified_run_flow to include the validation logic and handle the InvalidChatInputException appropriately.
…iterating over them to prevent potential errors
…Output

This commit adds an advanced option for storing messages in the ChatInput and ChatOutput components. By setting the `advanced` flag to `True`, the messages will be stored in the history. This provides more flexibility and control over message storage in the application.
@anovazzi1 anovazzi1 force-pushed the add_more_api_tests branch from 60df022 to 6f59af9 Compare July 12, 2024 17:56
@ogabrielluiz ogabrielluiz merged commit c47c358 into main Jul 12, 2024
27 checks passed
@ogabrielluiz ogabrielluiz deleted the add_more_api_tests branch July 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants