Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize filtering of vertices in useFlowStore #2662

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

ogabrielluiz
Copy link
Contributor

Refactor the filtering logic in the useFlowStore hook to optimize the performance. The code changes ensure that the nextVertices array is filtered correctly by excluding vertices that already exist in the last layer.

Refactor the filtering logic in the useFlowStore hook to optimize the performance. The code changes ensure that the nextVertices array is filtered correctly by excluding vertices that already exist in the last layer.
@ogabrielluiz ogabrielluiz requested a review from anovazzi1 July 12, 2024 16:16
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 12, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 12, 2024 16:16
@dosubot dosubot bot added the bug Something isn't working label Jul 12, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 12 Jul 24 16:17 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 12, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2024
@ogabrielluiz ogabrielluiz merged commit ef6d954 into main Jul 12, 2024
23 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/group_bug branch July 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants