Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust function that add incremental name on flows that already exists + tests #2645

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request addresses a critical bug where renaming a flow results in losing the folder reference. The fix involves adjusting the function that handles the addition of incremental names for flows that already exist. Additionally, tests have been added to ensure the functionality works correctly.

…ted flow from existing names to prevent naming conflicts
✅ (sideBarFolderButtons): add data-testid to delete folder button for testing
✅ (folders.spec.ts): update test to use new data-testid for delete folder button
✅ (generalBugs-shard-4.spec.ts): add new end-to-end test for flow operations
@Cristhianzl Cristhianzl self-assigned this Jul 11, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 11, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 11 Jul 24 20:28 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 11, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) July 12, 2024 16:41
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 12, 2024
@anovazzi1 anovazzi1 merged commit eb0a70f into main Jul 12, 2024
30 checks passed
@anovazzi1 anovazzi1 deleted the cz/fix-naming-flows branch July 12, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants