Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary encode from API key decryption #2641

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

Cristhianzl
Copy link
Member

♻️ (utils.py): simplify decryption logic by removing unnecessary type check

@Cristhianzl Cristhianzl requested a review from ogabrielluiz July 11, 2024 17:02
@Cristhianzl Cristhianzl self-assigned this Jul 11, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 11, 2024
@dosubot dosubot bot added bug Something isn't working python Pull requests that update Python code labels Jul 11, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 11, 2024 17:05
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 11 Jul 24 17:05 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 11, 2024
@ogabrielluiz ogabrielluiz merged commit 52db335 into main Jul 11, 2024
27 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix-api-key branch July 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants