Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Multiselect component to use 'values' prop instead of 'value' #2640

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This commit updates the Multiselect component to use the 'values' prop instead of the 'value' prop. The 'values' prop is more intuitive and aligns with the naming convention used in other components. This change ensures consistency and improves the readability of the code.

The code changes add a new 'is_list' field to the MultiselectInput class in the `inputs.py` file. This field is set to `True` by default and allows for the input to accept multiple selections. This enhancement improves the functionality of the MultiselectInput class by providing the ability to handle lists of options.
…lue'

This commit updates the Multiselect component to use the 'values' prop instead of the 'value' prop. The 'values' prop is more intuitive and aligns with the naming convention used in other components. This change ensures consistency and improves the readability of the code.
@ogabrielluiz ogabrielluiz requested a review from anovazzi1 July 11, 2024 17:00
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 11, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 11, 2024 17:01
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 11 Jul 24 17:01 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 11, 2024
@ogabrielluiz ogabrielluiz requested a review from Cristhianzl July 11, 2024 17:33
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogabrielluiz ogabrielluiz merged commit 7d75027 into main Jul 11, 2024
33 checks passed
@ogabrielluiz ogabrielluiz deleted the fix_multi_select branch July 11, 2024 20:21
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants