feat: Add milvus vector store #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
auto-merge was automatically disabled
July 12, 2024 02:16
Head branch was pushed to by a user without write access
|
@ogabrielluiz Hello, I've rebased the branch & solved conflicts to pass CI. Can you please help to review & merge the pull request? |
ogabrielluiz
approved these changes
Jul 12, 2024
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
auto-merge was automatically disabled
July 12, 2024 18:16
Head branch was pushed to by a user without write access
Signed-off-by: Jael Gu <[email protected]>
|
@ogabrielluiz Hello, I've resolved conflicts and rebased on the latest main again. The conflict and CI failures happened after a direct main merge due to new changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As request in both discussions:
This pull request adds Milvus to the vector store component. I've tested it at my local for both doc ingestion & query flow using Milvus vector store, Cohere embedding, and OpenAI chat.