Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug on row selection at IO modal #2627

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

The code changes in this commit optimize the filtering of messages in the SessionView component ad fix a bug on row selection. The useMemo hook is used to memoize the filteredMessages array, which improves performance by avoiding unnecessary re-rendering and fix a bug on row selection.

The code changes in this commit optimize the filtering of messages in the SessionView component. The useMemo hook is used to memoize the filteredMessages array, which improves performance by avoiding unnecessary re-rendering.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 10, 2024
@anovazzi1 anovazzi1 requested a review from lucaseduoli July 10, 2024 21:57
@dosubot dosubot bot added bug Something isn't working javascript Pull requests that update Javascript code labels Jul 10, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 10 Jul 24 21:58 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 10, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with you in person

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) July 12, 2024 15:18
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 12, 2024
@anovazzi1 anovazzi1 merged commit 229b868 into main Jul 12, 2024
26 checks passed
@anovazzi1 anovazzi1 deleted the fixSessionViewSelection branch July 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants