Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: azure embeddings models with fixed dimensions fail #2619

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: azure embeddings models with fixed dimensions fail #2619

merged 2 commits into from
Jul 10, 2024

Conversation

nicoloboschi
Copy link
Contributor

currently dimensions parameter is always passed as str or int making the langchain integration to fail (it accepts Optional[int]).
In this PR I also add back the dimensions to openai embeddings that has been lost in between the components refactor, originally implemented by @jordanrfrazier with #2146

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Jul 10, 2024
ogabrielluiz
ogabrielluiz approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 10, 2024
@ogabrielluiz ogabrielluiz merged commit 9c41b0c into langflow-ai:main Jul 10, 2024
27 checks passed
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 11, 2024
@nicoloboschi
fix: azure embeddings models with fixed dimensions fail (langflow-ai#…
4f06495 
…2619)

* fix: azure embeddings models with fixed dimensions fail

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9c41b0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoloboschi @ogabrielluiz