-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-implement logic to correctly save or update flow in the appropriate folder on autologin = false #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ (authContext): add setAllFlows and setSelectedFolder to AuthProvider ✨ (undrawCards): add folderIdUrl for better URL handling ✨ (collectionCard): add folder URL handling for navigation ✨ (use-delete-multiple): add setAllFlows and setSelectedFolder to handleDeleteMultiple ✨ (componentsComponent): add isLoadingFolders and setSelectedFolder ✨ (tabsComponent): add folder URL handling for tab navigation ✨ (flowsManagerStore): add folder URL handling in saveFlowDebounce ✨ (foldersStore.tsx): add setSelectedFolder method to manage selected folder state ♻️ (foldersStore.tsx): move setIsLoadingFolders call to improve loading state management ✨ (flowsManager/index.ts): add folderId parameter to saveFlow and saveFlowDebounce methods for better flow management ✨ (folders/index.ts): add setSelectedFolder method to FoldersStoreType for better folder state management
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
labels
Jul 9, 2024
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 09 Jul 24 18:14 UTC |
github-actions
bot
added
bug
Something isn't working
and removed
enhancement
New feature or request
bug
Something isn't working
labels
Jul 9, 2024
lucaseduoli
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 11, 2024
…priate folder on autologin = false (langflow-ai#2610) ♻️ (frontend): remove unused imports and variables in cardComponent ✨ (authContext): add setAllFlows and setSelectedFolder to AuthProvider ✨ (undrawCards): add folderIdUrl for better URL handling ✨ (collectionCard): add folder URL handling for navigation ✨ (use-delete-multiple): add setAllFlows and setSelectedFolder to handleDeleteMultiple ✨ (componentsComponent): add isLoadingFolders and setSelectedFolder ✨ (tabsComponent): add folder URL handling for tab navigation ✨ (flowsManagerStore): add folder URL handling in saveFlowDebounce ✨ (foldersStore.tsx): add setSelectedFolder method to manage selected folder state ♻️ (foldersStore.tsx): move setIsLoadingFolders call to improve loading state management ✨ (flowsManager/index.ts): add folderId parameter to saveFlow and saveFlowDebounce methods for better flow management ✨ (folders/index.ts): add setSelectedFolder method to FoldersStoreType for better folder state management (cherry picked from commit 0df06c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This pull request includes various improvements and feature additions to enhance folder and flow management across different components. Key changes include the removal of unused imports and variables, the addition of new methods for better state management, and improved URL handling for navigation.
Details - Generated by open commit
♻️ (frontend): remove unused imports and variables in cardComponent
✨ (authContext): add setAllFlows and setSelectedFolder to AuthProvider
✨ (undrawCards): add folderIdUrl for better URL handling
✨ (collectionCard): add folder URL handling for navigation
✨ (use-delete-multiple): add setAllFlows and setSelectedFolder to handleDeleteMultiple
✨ (componentsComponent): add isLoadingFolders and setSelectedFolder
✨ (tabsComponent): add folder URL handling for tab navigation
✨ (flowsManagerStore): add folder URL handling in saveFlowDebounce
✨ (foldersStore.tsx): add setSelectedFolder method to manage selected folder state
♻️ (foldersStore.tsx): move setIsLoadingFolders call to improve loading state management
✨ (flowsManager/index.ts): add folderId parameter to saveFlow and saveFlowDebounce methods for better flow management
✨ (folders/index.ts): add setSelectedFolder method to FoldersStoreType for better folder state management