Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-implement logic to correctly save or update flow in the appropriate folder on autologin = false #2610

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Jul 9, 2024

Changes Overview

This pull request includes various improvements and feature additions to enhance folder and flow management across different components. Key changes include the removal of unused imports and variables, the addition of new methods for better state management, and improved URL handling for navigation.

Details - Generated by open commit

♻️ (frontend): remove unused imports and variables in cardComponent
✨ (authContext): add setAllFlows and setSelectedFolder to AuthProvider
✨ (undrawCards): add folderIdUrl for better URL handling
✨ (collectionCard): add folder URL handling for navigation
✨ (use-delete-multiple): add setAllFlows and setSelectedFolder to handleDeleteMultiple
✨ (componentsComponent): add isLoadingFolders and setSelectedFolder
✨ (tabsComponent): add folder URL handling for tab navigation
✨ (flowsManagerStore): add folder URL handling in saveFlowDebounce
✨ (foldersStore.tsx): add setSelectedFolder method to manage selected folder state
♻️ (foldersStore.tsx): move setIsLoadingFolders call to improve loading state management
✨ (flowsManager/index.ts): add folderId parameter to saveFlow and saveFlowDebounce methods for better flow management
✨ (folders/index.ts): add setSelectedFolder method to FoldersStoreType for better folder state management

✨ (authContext): add setAllFlows and setSelectedFolder to AuthProvider
✨ (undrawCards): add folderIdUrl for better URL handling
✨ (collectionCard): add folder URL handling for navigation
✨ (use-delete-multiple): add setAllFlows and setSelectedFolder to handleDeleteMultiple
✨ (componentsComponent): add isLoadingFolders and setSelectedFolder
✨ (tabsComponent): add folder URL handling for tab navigation
✨ (flowsManagerStore): add folder URL handling in saveFlowDebounce

✨ (foldersStore.tsx): add setSelectedFolder method to manage selected folder state
♻️ (foldersStore.tsx): move setIsLoadingFolders call to improve loading state management
✨ (flowsManager/index.ts): add folderId parameter to saveFlow and saveFlowDebounce methods for better flow management
✨ (folders/index.ts): add setSelectedFolder method to FoldersStoreType for better folder state management
@Cristhianzl Cristhianzl self-assigned this Jul 9, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 09 Jul 24 18:14 UTC

@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request bug Something isn't working labels Jul 9, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2024
@ogabrielluiz ogabrielluiz merged commit 0df06c0 into main Jul 9, 2024
23 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix-folders branch July 9, 2024 22:29
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 11, 2024
…priate folder on autologin = false (langflow-ai#2610)

♻️ (frontend): remove unused imports and variables in cardComponent
✨ (authContext): add setAllFlows and setSelectedFolder to AuthProvider
✨ (undrawCards): add folderIdUrl for better URL handling
✨ (collectionCard): add folder URL handling for navigation
✨ (use-delete-multiple): add setAllFlows and setSelectedFolder to handleDeleteMultiple
✨ (componentsComponent): add isLoadingFolders and setSelectedFolder
✨ (tabsComponent): add folder URL handling for tab navigation
✨ (flowsManagerStore): add folder URL handling in saveFlowDebounce

✨ (foldersStore.tsx): add setSelectedFolder method to manage selected folder state
♻️ (foldersStore.tsx): move setIsLoadingFolders call to improve loading state management
✨ (flowsManager/index.ts): add folderId parameter to saveFlow and saveFlowDebounce methods for better flow management
✨ (folders/index.ts): add setSelectedFolder method to FoldersStoreType for better folder state management

(cherry picked from commit 0df06c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants