fix: show loading component state while images arent fully loaded #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 09 Jul 24 18:13 UTC |
dosubot
bot
added
bug
github-actions
bot
added
bug
…process data on the server side ♻️ (ProfilePictureForm): simplify state management by removing redundant loading state
…low-ai/langflow into cz/fix-profile-img-loading
dosubot
bot
added
size:M
…rofilePicturesQueryResponse for clarity ♻️ (use-preload-images.tsx): add loading check to useEffect to prevent unnecessary execution ♻️ (profilePictureChooserComponent): update profilePictures prop type to handle undefined and add loading to usePreloadImages ♻️ (ProfilePictureForm): remove unnecessary state and use response directly from useGetProfilePicturesQuery
…fect dependency array to ensure images are preloaded correctly
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 11, 2024
…ngflow-ai#2609) * ✨ (ProfilePictureForm): add loading state to handle initial loading state * ♻️ (use-get-profile-pictures.ts): refactor profile pictures query to process data on the server side ♻️ (ProfilePictureForm): simplify state management by removing redundant loading state * ♻️ (use-get-profile-pictures.ts): rename ProfilePicturesResponse to ProfilePicturesQueryResponse for clarity ♻️ (use-preload-images.tsx): add loading check to useEffect to prevent unnecessary execution ♻️ (profilePictureChooserComponent): update profilePictures prop type to handle undefined and add loading to usePreloadImages ♻️ (ProfilePictureForm): remove unnecessary state and use response directly from useGetProfilePicturesQuery * 🐛 (use-preload-images.tsx): add missing dependency 'loading' to useEffect dependency array to ensure images are preloaded correctly (cherry picked from commit 7174e6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ (ProfilePictureForm): add loading state to handle initial loading state