fixing ThreadingInMemoryCache usage #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
ogabrielluiz
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Wow @himan-k!
Thank you for this. This looks great to me!
Just fix those small issues and this should be merged.
…ssues along with missing documentation about the caching options.
|
Hey @ogabrielluiz , I am not sure if i have checkin permissions. please check. thank you. |
ogabrielluiz
approved these changes
Jul 10, 2024
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 11, 2024
* ThreadingInMemoryCache usage is broken. This commit addresses those issues along with missing documentation about the caching options. * make lint & make unit_tests fixes * removing unnecessary changes from unclear test results in last run * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> (cherry picked from commit 7414a01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadingInMemoryCache usage is broken. This commit addresses those issues along with missing documentation about the caching options.