Skip to content

fix: stream option is not working with tracing enabled #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Jul 9, 2024

Fixes #2598

This is a regression introduced by the langsmith integration. It only happens when the model are configured with stream=True.

There are 2 issues:

  1. The iterator is being consumed while converting data for langsmith so the end result is empty stream
  2. there's an error cannot create 'generator' instances popping up in the logs during the conversion

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 09 Jul 24 07:28 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 9, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
@nicoloboschi nicoloboschi changed the title fix: cannot create 'generator' instances fix: stream option is not working with tracing enabled Jul 9, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 9, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 9, 2024 13:07
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 9, 2024
Copy link
Collaborator

@zzzming zzzming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz merged commit 21adbd5 into langflow-ai:main Jul 9, 2024
32 checks passed
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
)

* fix: cannot create 'generator' instances

* fix: cannot create 'generator' instances

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
)

* fix: cannot create 'generator' instances

* fix: cannot create 'generator' instances

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 21adbd5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLm streaming is failed using version 1.0.6
3 participants