Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make chat lock when building #2592

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: make chat lock when building #2592

merged 1 commit into from
Jul 8, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request fixes a bug where the chat was not being locked properly during the build process. The bug was causing the chat to remain unlocked even when the build was in progress. This pull request adds the necessary code to properly lock and unlock the chat during the build process.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 8, 2024
@anovazzi1 anovazzi1 requested a review from ogabrielluiz July 8, 2024 21:14
@dosubot dosubot bot added the bug Something isn't working label Jul 8, 2024
@anovazzi1 anovazzi1 changed the title Fix lock chat bug fix: lock chat bug Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 08 Jul 24 21:15 UTC

@ogabrielluiz ogabrielluiz changed the title fix: lock chat bug fix: make chat lock when building Jul 8, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 8, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 8, 2024 21:21
@ogabrielluiz ogabrielluiz merged commit 311b663 into main Jul 8, 2024
31 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2024
@ogabrielluiz ogabrielluiz deleted the fixLockChat branch July 8, 2024 21:22
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 8, 2024
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
Fix:lock chat bug
(cherry picked from commit 311b663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants