Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant superuser only if it has never logged in #2582

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

ogabrielluiz
Copy link
Contributor

The code changes in utils.py check if the superuser exists and if it has never logged in. If both conditions are true, the superuser is deleted from the database. This improves the efficiency and security of the application.

The code changes in `utils.py` check if the superuser exists and if it has never logged in. If both conditions are true, the superuser is deleted from the database. This improves the efficiency and security of the application.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 8, 2024
@ogabrielluiz ogabrielluiz requested a review from Cristhianzl July 8, 2024 15:16
@dosubot dosubot bot added the python Pull requests that update Python code label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 08 Jul 24 15:17 UTC

@ogabrielluiz ogabrielluiz changed the title fix: Remove redundant superuser only if it has never logged in fix: remove redundant superuser only if it has never logged in Jul 8, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 8, 2024 15:17
@github-actions github-actions bot added the bug Something isn't working label Jul 8, 2024
…Interceptor

🐛 (foldersStore.tsx): add optional chaining to prevent potential runtime errors
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 8, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 8, 2024
@ogabrielluiz ogabrielluiz requested a review from anovazzi1 July 8, 2024 15:58
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2024
@ogabrielluiz ogabrielluiz merged commit 7e22218 into main Jul 8, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the change_superuser_delete branch July 8, 2024 16:37
ogabrielluiz added a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
…low-ai#2582)

fix: Remove redundant superuser only if it has never logged in

The code changes in `utils.py` check if the superuser exists and if it has never logged in. If both conditions are true, the superuser is deleted from the database. This improves the efficiency and security of the application.
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
…low-ai#2582)

fix: Remove redundant superuser only if it has never logged in

The code changes in `utils.py` check if the superuser exists and if it has never logged in. If both conditions are true, the superuser is deleted from the database. This improves the efficiency and security of the application.

(cherry picked from commit 7e22218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants