-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor messages API and session view #2577
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 08 Jul 24 13:24 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yo!
Apart from not using the defined constant this looks good.
* feat: create boilerplate code for messages api * centering functionality on one component * refactor useGetMessages * update to new type format * refactor Session view and get messages logic * update to session view to useGetMessageQuery * remove old api call * feat: create boilerplate code for messages api * centering functionality on one component * refactor useGetMessages * update to new type format * refactor Session view and get messages logic * update to session view to useGetMessageQuery * remove old api call * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
* feat: create boilerplate code for messages api * centering functionality on one component * refactor useGetMessages * update to new type format * refactor Session view and get messages logic * update to session view to useGetMessageQuery * remove old api call * feat: create boilerplate code for messages api * centering functionality on one component * refactor useGetMessages * update to new type format * refactor Session view and get messages logic * update to session view to useGetMessageQuery * remove old api call * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Cristhian Zanforlin Lousa <[email protected]> (cherry picked from commit ca3367d)
This pull request includes several changes to the messages API and the session view component.
The changes include:
Refactoring the messages API to use separate files get messages.
Updating the session view component to use the new messages API.
Removing unused code related to the messages table.
Adding a loading indicator to the session view component.
These changes improve the organization and performance of the messages API and enhance the user experience in the session view component.