Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor messages API and session view #2577

Merged
merged 17 commits into from
Jul 8, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

This pull request includes several changes to the messages API and the session view component.

The changes include:

  • Refactoring the messages API to use separate files get messages.

  • Updating the session view component to use the new messages API.

  • Removing unused code related to the messages table.

  • Adding a loading indicator to the session view component.

These changes improve the organization and performance of the messages API and enhance the user experience in the session view component.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 8, 2024
@dosubot dosubot bot added enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 08 Jul 24 13:24 UTC

@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Jul 8, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo!

Apart from not using the defined constant this looks good.

src/frontend/src/controllers/API/index.ts Show resolved Hide resolved
Cristhianzl

This comment was marked as resolved.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2024
@anovazzi1 anovazzi1 requested a review from ogabrielluiz July 8, 2024 21:04
@ogabrielluiz ogabrielluiz merged commit ca3367d into main Jul 8, 2024
23 checks passed
@ogabrielluiz ogabrielluiz deleted the refactorMessage branch July 8, 2024 21:05
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
* feat: create boilerplate code for messages api

* centering functionality on one component

* refactor useGetMessages

* update to new type format

* refactor Session view and get messages logic

* update to session view to useGetMessageQuery

* remove old api call

* feat: create boilerplate code for messages api

* centering functionality on one component

* refactor useGetMessages

* update to new type format

* refactor Session view and get messages logic

* update to session view to useGetMessageQuery

* remove old api call

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
* feat: create boilerplate code for messages api

* centering functionality on one component

* refactor useGetMessages

* update to new type format

* refactor Session view and get messages logic

* update to session view to useGetMessageQuery

* remove old api call

* feat: create boilerplate code for messages api

* centering functionality on one component

* refactor useGetMessages

* update to new type format

* refactor Session view and get messages logic

* update to session view to useGetMessageQuery

* remove old api call

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
(cherry picked from commit ca3367d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants