Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove uneceessary logic to disable button on search components/flows #2540

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix: remove uneceessary logic to disable button on search components/flows #2540

merged 1 commit into from
Jul 4, 2024

Conversation

Cristhianzl
Copy link
Member

♻️ (index.tsx): simplify disableInputSearch logic by removing redundant conditions

@Cristhianzl Cristhianzl requested a review from anovazzi1 July 4, 2024 19:57
@Cristhianzl Cristhianzl self-assigned this Jul 4, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 04 Jul 24 19:58 UTC

@github-actions github-actions bot added the bug Something isn't working label Jul 4, 2024
anovazzi1
anovazzi1 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2024
@Cristhianzl Cristhianzl merged commit 4f586ad into main Jul 4, 2024
24 checks passed
@Cristhianzl Cristhianzl deleted the cz/fixErrorInputSearch branch July 4, 2024 20:10
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
@Cristhianzl @ogabrielluiz
fix: remove uneceessary logic to disable button on search components/…
1774243 
…flows (langflow-ai#2540)

♻️ (index.tsx): simplify disableInputSearch logic by removing redundant conditions
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
@Cristhianzl @nicoloboschi
fix: remove uneceessary logic to disable button on search components/…
f57fa54 
…flows (langflow-ai#2540)

♻️ (index.tsx): simplify disableInputSearch logic by removing redundant conditions

(cherry picked from commit 4f586ad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

Assignees

@Cristhianzl Cristhianzl

Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cristhianzl @anovazzi1