-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate chains and memories to Component syntax #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicoloboschi
commented
Jul 4, 2024
- Memory are now compatible with chains. Instead of having reader/writer we use the langchain ChatBaseMemory abstraction. In the future I expect the builtin langflow memory to be compatible
- Chains are rewritten and updated. Removed deprecated LLMChain and RetrievalQAWithSources because the sources weren't exposed anyway
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
enhancement
New feature or request
labels
Jul 4, 2024
nicoloboschi
force-pushed
the
migrate-chains
branch
from
July 4, 2024 12:08
497b684
to
cb4f0d0
Compare
nicoloboschi
force-pushed
the
migrate-chains
branch
from
July 4, 2024 12:30
e0b859d
to
1745fd2
Compare
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 04 Jul 24 14:11 UTC |
…0ms to ensure elements are fully loaded before interaction
ogabrielluiz
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Jul 5, 2024
ogabrielluiz
added a commit
to yaitec/langflow
that referenced
this pull request
Jul 9, 2024
* feat: migrate chains and memories to Component syntax * use base class * add classes * [autofix.ci] apply automated fixes * fix tests * fix tests * ✅ (filterSidebar.spec.ts): increase waitForTimeout from 1000ms to 2000ms to ensure elements are fully loaded before interaction --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: cristhianzl <[email protected]> Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
nicoloboschi
added a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 10, 2024
* feat: migrate chains and memories to Component syntax * use base class * add classes * [autofix.ci] apply automated fixes * fix tests * fix tests * ✅ (filterSidebar.spec.ts): increase waitForTimeout from 1000ms to 2000ms to ensure elements are fully loaded before interaction --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: cristhianzl <[email protected]> Co-authored-by: Cristhian Zanforlin Lousa <[email protected]> (cherry picked from commit eb34205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.