Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate chains and memories to Component syntax #2528

Merged
merged 11 commits into from
Jul 5, 2024

Conversation

nicoloboschi
Copy link
Contributor

  • Memory are now compatible with chains. Instead of having reader/writer we use the langchain ChatBaseMemory abstraction. In the future I expect the builtin langflow memory to be compatible
  • Chains are rewritten and updated. Removed deprecated LLMChain and RetrievalQAWithSources because the sources weren't exposed anyway

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Jul 4, 2024
@ogabrielluiz ogabrielluiz self-requested a review July 4, 2024 12:13
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has mentioned issues

Result

Pull request is invalid.

Reason

  • Pull request does not mention any issues

Last Modified at 04 Jul 24 14:11 UTC

@ogabrielluiz ogabrielluiz requested a review from namastex888 July 5, 2024 14:52
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 5, 2024 16:23
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 5, 2024
@ogabrielluiz ogabrielluiz merged commit eb34205 into langflow-ai:main Jul 5, 2024
31 checks passed
ogabrielluiz added a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
* feat: migrate chains and memories to Component syntax

* use base class

* add classes

* [autofix.ci] apply automated fixes

* fix tests

* fix tests

* ✅ (filterSidebar.spec.ts): increase waitForTimeout from 1000ms to 2000ms to ensure elements are fully loaded before interaction

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: cristhianzl <[email protected]>
Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
* feat: migrate chains and memories to Component syntax

* use base class

* add classes

* [autofix.ci] apply automated fixes

* fix tests

* fix tests

* ✅ (filterSidebar.spec.ts): increase waitForTimeout from 1000ms to 2000ms to ensure elements are fully loaded before interaction

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: cristhianzl <[email protected]>
Co-authored-by: Cristhian Zanforlin Lousa <[email protected]>
(cherry picked from commit eb34205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants