Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spec files cant find .env variable on CI #2514

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Conversation

Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Jul 3, 2024

This pull request addresses the issue where the CI environment is unable to access the .env variable values required by the frontend specs.

@Cristhianzl Cristhianzl self-assigned this Jul 3, 2024
@Cristhianzl Cristhianzl changed the title bugfix: add env import to spec files correctly bugfix: spec files cant find .env variable on CI Jul 3, 2024
@Cristhianzl Cristhianzl changed the title bugfix: spec files cant find .env variable on CI fix: spec files cant find .env variable on CI Jul 3, 2024
@Cristhianzl Cristhianzl requested a review from ogabrielluiz July 3, 2024 20:36
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2024
@Cristhianzl Cristhianzl marked this pull request as ready for review July 3, 2024 20:54
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 3, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 3, 2024 20:59
@ogabrielluiz ogabrielluiz disabled auto-merge July 3, 2024 21:07
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 3, 2024 21:07
@ogabrielluiz ogabrielluiz merged commit fb21fdd into main Jul 4, 2024
27 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/addDotEnvToTests branch July 4, 2024 01:36
ogabrielluiz pushed a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
* bugfix: add env import to spec files correctly

* 🔧 (ci.yml): fix indentation for consistency and readability in CI workflow

* ci: add inputs to workflow

* bugfix: improve flaky test general bugs to run smoothier on CI

* ci: add more shards to improve tests on CI
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
* bugfix: add env import to spec files correctly

* 🔧 (ci.yml): fix indentation for consistency and readability in CI workflow

* ci: add inputs to workflow

* bugfix: improve flaky test general bugs to run smoothier on CI

* ci: add more shards to improve tests on CI

(cherry picked from commit fb21fdd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants