-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: spec files cant find .env variable on CI #2514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cristhianzl
changed the title
bugfix: add env import to spec files correctly
bugfix: spec files cant find .env variable on CI
Jul 3, 2024
Cristhianzl
changed the title
bugfix: spec files cant find .env variable on CI
fix: spec files cant find .env variable on CI
Jul 3, 2024
ogabrielluiz
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
bug
Something isn't working
labels
Jul 3, 2024
…ble, fallback to secrets for OPENAI_API_KEY and STORE_API_KEY
…PI_KEY and STORE_API_KEY
ogabrielluiz
pushed a commit
to yaitec/langflow
that referenced
this pull request
Jul 9, 2024
* bugfix: add env import to spec files correctly * 🔧 (ci.yml): fix indentation for consistency and readability in CI workflow * ci: add inputs to workflow * bugfix: improve flaky test general bugs to run smoothier on CI * ci: add more shards to improve tests on CI
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 10, 2024
* bugfix: add env import to spec files correctly * 🔧 (ci.yml): fix indentation for consistency and readability in CI workflow * ci: add inputs to workflow * bugfix: improve flaky test general bugs to run smoothier on CI * ci: add more shards to improve tests on CI (cherry picked from commit fb21fdd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where the CI environment is unable to access the .env variable values required by the frontend specs.