fix: make webhook api call honor webhook component as input #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
nicoloboschi
reviewed
Jul 4, 2024
dosubot
bot
added
size:M
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 04 Jul 24 13:57 UTC |
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 04 Jul 24 13:58 UTC |
|
Tested here, and it is still running isolated components. And I just tested both
With With But at least that issue with async code that I had mentioned is gone. |
… multiple keywords for improved flexibility and readability
…list for handling webhook inputs in the graph schema
…ed on webhook or chat component presence in input vertices
…t ID based on priority list of input types
… Graph class for better readability and maintainability
ogabrielluiz
force-pushed
the
webhook_start
branch
from
c1e3fa7 to
ef754e0
Compare
…I key in environment variables before running tests
dosubot
bot
added
size:L
ogabrielluiz
requested review from
italojohnny
and removed request for
zzzming and
nicoloboschi
Should be good now. |
|
Working as expected now! |
vasconceloscezar
approved these changes
Jul 4, 2024
ogabrielluiz
added a commit
to yaitec/langflow
that referenced
this pull request
Jul 9, 2024
…-ai#2511) * refactor(base.py): refactor logic to find start_component_id based on multiple keywords for improved flexibility and readability * feat(schema.py): add WebhookInput component type to INPUT_COMPONENTS list for handling webhook inputs in the graph schema * refactor(base.py): refactor logic to determine start_component_id based on webhook or chat component presence in input vertices * refactor: prioritize webhook component for determining start_component_id * feat(utils.py): add function find_start_component_id to find component ID based on priority list of input types * refactor(graph/base.py): refactor logic to find start component id in Graph class for better readability and maintainability * test(test_webhook.py): override pytest fixture to check for OpenAI API key in environment variables before running tests * test(test_webhook.py): update webhook json * feat(schema.py): update WebhookInput component type name * refactor: log package run telemetry in simplified_run_flow * test: add test for webhook flow on run endpoint * refactor(graph/base.py): skip unbuilt vertices when getting vertex outputs in Graph class * refactor: simplify data_input assignment in LCTextSplitterComponent * refactor: remove unused build method in CharacterTextSplitterComponent * refactor: update imports in CharacterTextSplitter.py
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 10, 2024
…-ai#2511) * refactor(base.py): refactor logic to find start_component_id based on multiple keywords for improved flexibility and readability * feat(schema.py): add WebhookInput component type to INPUT_COMPONENTS list for handling webhook inputs in the graph schema * refactor(base.py): refactor logic to determine start_component_id based on webhook or chat component presence in input vertices * refactor: prioritize webhook component for determining start_component_id * feat(utils.py): add function find_start_component_id to find component ID based on priority list of input types * refactor(graph/base.py): refactor logic to find start component id in Graph class for better readability and maintainability * test(test_webhook.py): override pytest fixture to check for OpenAI API key in environment variables before running tests * test(test_webhook.py): update webhook json * feat(schema.py): update WebhookInput component type name * refactor: log package run telemetry in simplified_run_flow * test: add test for webhook flow on run endpoint * refactor(graph/base.py): skip unbuilt vertices when getting vertex outputs in Graph class * refactor: simplify data_input assignment in LCTextSplitterComponent * refactor: remove unused build method in CharacterTextSplitterComponent * refactor: update imports in CharacterTextSplitter.py (cherry picked from commit 03329b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webhook API call runs all components but it should use the Webhook Input as start component and just run that path.