Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global components api bug #2478

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix: global components api bug #2478

merged 2 commits into from
Jul 2, 2024

Conversation

lucaseduoli
Copy link
Collaborator

Fixed bug where global variables that didn't exist didn't trigger the change of load_from_db to false, causing the API Key attributed to the secret_str components to not work.

@lucaseduoli lucaseduoli requested a review from ogabrielluiz July 2, 2024 13:06
@lucaseduoli lucaseduoli self-assigned this Jul 2, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jul 2, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 2, 2024 13:07
@lucaseduoli lucaseduoli changed the title Fix Global Components bug fix: global components api bug Jul 2, 2024
@ogabrielluiz ogabrielluiz merged commit c1947a0 into main Jul 2, 2024
21 of 39 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/api_bug branch July 2, 2024 13:10
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 2, 2024
* removed unused console.logs

* Fixed load_from_db not being updated

(cherry picked from commit c1947a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants