-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Spider Web Scraper & Crawler #2439
feat: add Spider Web Scraper & Crawler #2439
Conversation
except Exception as e: | ||
raise Exception(f"Error: {str(e)}") | ||
|
||
records = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should change this:
) -> Data:
To this:
) -> list[Data]:
Screencast showing how it works Screencast.from.2024-06-29.14-50-38.webm |
Wow. This is nice, @WilliamEspegren Thank you! I'll approve it ASAP. |
Have you seen our new way of building components? |
No, I assume this is not the way since you are mentioning it? |
Take a look at the OpenAIModelComponent:
|
@ogabrielluiz I actually did that first: bbd7136 but I got errors |
This:
When trying to use the component, I get the following error:
|
@ogabrielluiz any idea why the code in the comment above fails? |
You should inherit from |
Thank you! The component now builds. The problem now is that the component has no output. I have looked at and tried to replicate how the OpenAI does it build(), but nothing has worked :( |
@ogabrielluiz just bringing this to your attention :) |
Hey @WilliamEspegren You have to set the
|
Screencast.from.2024-07-09.20-40-55.webm outputs = [
Output(display_name="Markdown", name="content", method="build"),
Output(display_name="URL", name="url", method="build"),
] When I have the "outputs" above, the component doesn't even show up. When I comment out the "outputs" the component shows up, but there is no outputs on the node. @ogabrielluiz |
17eec88
to
5e1e73d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
except Exception as e: | ||
raise Exception(f"Error: {str(e)}") | ||
|
||
records = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should change this:
) -> Data:
To this:
) -> list[Data]:
Should I solve the merge conflicts? |
@ogabrielluiz just pinging for attention |
0a421d8
to
9eb3e8a
Compare
Add Spider, the fastest open source scraper & crawler that returns LLM-ready data.
Twitter: @WilliamEspegren