Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Global Variables #2430

Merged
merged 32 commits into from
Jul 1, 2024
Merged

Fix Global Variables #2430

merged 32 commits into from
Jul 1, 2024

Conversation

lucaseduoli
Copy link
Collaborator

Fix global variables that does not work with default applied fields, on starter flows.

@lucaseduoli lucaseduoli requested a review from ogabrielluiz June 28, 2024 13:58
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 28, 2024
@lucaseduoli lucaseduoli self-assigned this Jun 28, 2024
@dosubot dosubot bot added bug Something isn't working javascript Pull requests that update Javascript code python Pull requests that update Python code size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 28, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase dev here.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jun 28, 2024
@italojohnny italojohnny self-requested a review June 28, 2024 21:44
Copy link
Member

@italojohnny italojohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 28, 2024
@italojohnny italojohnny requested a review from ogabrielluiz June 28, 2024 21:59
@ogabrielluiz ogabrielluiz enabled auto-merge June 30, 2024 14:17
@italojohnny italojohnny disabled auto-merge July 1, 2024 13:54
@italojohnny italojohnny enabled auto-merge July 1, 2024 13:54
@ogabrielluiz ogabrielluiz disabled auto-merge July 1, 2024 16:30
@ogabrielluiz ogabrielluiz merged commit f3df98a into dev Jul 1, 2024
1 check was pending
@ogabrielluiz ogabrielluiz deleted the fix/global_variables branch July 1, 2024 16:31
ogabrielluiz added a commit that referenced this pull request Jul 1, 2024
* chore: update linting workflows to include dev branch in merge_group

* Update README.md

Add 1.0 banner

* Update README.md

* chore: update package versions in pyproject.toml files

* Added db value to every onChange on parameters

* Refactored global variables to find variables on the first render, and to execute just one onChange to update both values and db

* Changed group recursion function to include check for global variables already applied or outdated

* Removed already inserted component check for default fields on global variables

* Fixed import error

* Added required parameters to update node on drop

* Removed check for unused hardcoded name

* Added global variables handling on nodes when adding a flow

* Fixed maximum update depth when deleting used global variable

* Fixed type error on addNewVariableButton modal

* Fixed openai api key on starter flows

* Fixed values to get the .env values by default on the starter projects

* Formatted flows

* fix erros reported by mypy

* [autofix.ci] apply automated fixes

* 🐛 (prototypes/__init__.py): fix missing comma in the list of imported components to prevent syntax error

* chore: Fix type hinting in ConditionalRouterComponent

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Rodrigo Nader <[email protected]>
Co-authored-by: italojohnny <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants