-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Global Variables #2430
Merged
Merged
Fix Global Variables #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jun 28, 2024
dosubot
bot
added
bug
Something isn't working
javascript
Pull requests that update Javascript code
python
Pull requests that update Python code
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Jun 28, 2024
ogabrielluiz
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should rebase dev here.
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Jun 28, 2024
…d to execute just one onChange to update both values and db
…s already applied or outdated
lucaseduoli
force-pushed
the
fix/global_variables
branch
from
June 28, 2024 20:27
0058369
to
28318c8
Compare
italojohnny
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ogabrielluiz
approved these changes
Jun 30, 2024
… components to prevent syntax error
ogabrielluiz
added a commit
that referenced
this pull request
Jul 1, 2024
* chore: update linting workflows to include dev branch in merge_group * Update README.md Add 1.0 banner * Update README.md * chore: update package versions in pyproject.toml files * Added db value to every onChange on parameters * Refactored global variables to find variables on the first render, and to execute just one onChange to update both values and db * Changed group recursion function to include check for global variables already applied or outdated * Removed already inserted component check for default fields on global variables * Fixed import error * Added required parameters to update node on drop * Removed check for unused hardcoded name * Added global variables handling on nodes when adding a flow * Fixed maximum update depth when deleting used global variable * Fixed type error on addNewVariableButton modal * Fixed openai api key on starter flows * Fixed values to get the .env values by default on the starter projects * Formatted flows * fix erros reported by mypy * [autofix.ci] apply automated fixes * 🐛 (prototypes/__init__.py): fix missing comma in the list of imported components to prevent syntax error * chore: Fix type hinting in ConditionalRouterComponent * [autofix.ci] apply automated fixes --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> Co-authored-by: Rodrigo Nader <[email protected]> Co-authored-by: italojohnny <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
python
Pull requests that update Python code
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix global variables that does not work with default applied fields, on starter flows.