Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(astradb): make fields required #2428

Merged
merged 15 commits into from
Jul 2, 2024
Merged

fix(astradb): make fields required #2428

merged 15 commits into from
Jul 2, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Jun 28, 2024 •
edited
Loading

Made token, endpoint and collection required since otherwise it will fail at runtime

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 28, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 28, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 1, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge July 1, 2024 18:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Cannot auto-update because of conflicts.

@ogabrielluiz ogabrielluiz changed the title astradb: make fields required fix: astradb, make fields required Jul 1, 2024
@ogabrielluiz ogabrielluiz changed the title fix: astradb, make fields required fix(astradb): make fields required Jul 1, 2024
ogabrielluiz
ogabrielluiz approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Cannot auto-update because of conflicts.

auto-merge was automatically disabled July 2, 2024 13:11

Merge commits are not allowed on this repository

@nicoloboschi nicoloboschi merged commit 6ef7776 into langflow-ai:main Jul 2, 2024
1 check passed
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 2, 2024
@nicoloboschi
fix(astradb): make fields required (langflow-ai#2428)
c88a80f 
* astradb: make fields required

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 6ef7776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoloboschi @ogabrielluiz