feat: add tests improvements to pipeline CI #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ter modal handling to improve test flow
dosubot
bot
added
the
size:XL
596050
reviewed
Jun 27, 2024
src/frontend/src/CustomNodes/GenericNode/components/handleRenderComponent/index.tsx
Outdated
Show resolved
Hide resolved
596050
reviewed
Jun 27, 2024
src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx
Outdated
Show resolved
Hide resolved
|
Cannot auto-update because of conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces several improvements and changes aimed at enhancing the test structure and codebase maintainability. The key changes include breaking tests into smaller files to distribute across more shards, replacing XPath locators with test ID locators, and performing a general code refactor.
Changes
Tests have been split into multiple files to better fit across more shards. This change aims to improve test execution efficiency and parallelization.
All locators previously using XPath have been updated to use data-testid attributes. This change improves the reliability and readability of the locators.
The codebase has undergone a general refactor to improve maintainability and readability. This includes:
Renaming variables for better clarity.
Extracting reusable functions and components.
Improving code comments and documentation.