Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image Display Issue on Windows by Setting a Static Path #2382

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

italojohnny
Copy link
Member

This PR addresses the issue of image display on Windows systems by editing the string that determines the image path. By setting a fixed path for the images, we ensure consistent display across different environments.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. bug Something isn't working labels Jun 26, 2024
@ogabrielluiz ogabrielluiz changed the base branch from main to dev June 26, 2024 19:30
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on Windows and it's working.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2024
@ogabrielluiz ogabrielluiz merged commit 5d06cf7 into dev Jun 26, 2024
5 checks passed
@ogabrielluiz ogabrielluiz deleted the lf/fix_img_windows branch June 26, 2024 22:41
ogabrielluiz pushed a commit that referenced this pull request Jun 27, 2024
ogabrielluiz pushed a commit that referenced this pull request Jun 27, 2024
ogabrielluiz pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants