Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor RunnableVerticesManager to consider inactivated vertices in is_vertex_runnable and find_runnable_predecessors_for_successors #2378

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Fixes an error where inactivated components would be considered runnable.

…ces in is_vertex_runnable and find_runnable_predecessors_for_successors
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 26, 2024
@dosubot dosubot bot added bug Something isn't working python Pull requests that update Python code labels Jun 26, 2024
…nnable and find_runnable_predecessors_for_successors
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2024
@ogabrielluiz ogabrielluiz disabled auto-merge June 26, 2024 21:04
@ogabrielluiz ogabrielluiz enabled auto-merge June 26, 2024 21:04
@ogabrielluiz ogabrielluiz disabled auto-merge June 26, 2024 21:59
@ogabrielluiz ogabrielluiz merged commit 755a30a into dev Jun 26, 2024
1 check was pending
@ogabrielluiz ogabrielluiz deleted the verify_stop_flow branch June 26, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants