Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition stop #2363

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Fix condition stop #2363

merged 4 commits into from
Jun 26, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request fixes a condition in the stop method. Previously, the method would raise a ValueError if output_name was not provided, even if it was set to None. This pull request updates the condition to only raise the ValueError if output_name is not provided and is not set to None. This allows for more flexibility when calling the stop method.

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 10:11pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 25, 2024
@anovazzi1 anovazzi1 requested a review from italojohnny June 25, 2024 22:11
@dosubot dosubot bot added the bug Something isn't working label Jun 25, 2024
Copy link
Member

@italojohnny italojohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@anovazzi1 anovazzi1 enabled auto-merge June 25, 2024 22:19
@anovazzi1 anovazzi1 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into dev with commit 99d3227 Jun 26, 2024
12 of 13 checks passed
@anovazzi1 anovazzi1 deleted the fix_self_stop branch June 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants