Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow settings validation and save button #2360

Merged
merged 9 commits into from
Jun 26, 2024
Merged

Fix flow settings validation and save button #2360

merged 9 commits into from
Jun 26, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request fixes the validation and save button behavior in the flow settings modal. Previously, the save button was not disabled when it should have been, and the endpoint name validation was not working correctly. This PR updates the validation logic and ensures that the save button is disabled when necessary.

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 10:33pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 25, 2024
@dosubot dosubot bot added bug Something isn't working javascript Pull requests that update Javascript code labels Jun 25, 2024
@anovazzi1 anovazzi1 requested a review from carlosrcoelho June 25, 2024 20:58
@vasconceloscezar
Copy link
Collaborator

When I just change the description, it throws an error about endpoint error name, making me put something as the name.

image

@vasconceloscezar vasconceloscezar self-requested a review June 25, 2024 21:15
Copy link

vercel bot commented Jun 25, 2024

Deployment failed with the following error:

Resource is limited - try again in 290 ms (more than 100, code: "api-deployments-free-per-day").

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@vasconceloscezar
Copy link
Collaborator

Kinda as it was before, but with a wierder behavior.

It doesn't matter if I change the description or the endpoint, it doesn't activate the save button.
The endpoint is saving "on its own", even without clicking save, if I edit it and close the modal, the value was saved there.

https://jam.dev/c/b6188fa8-c13f-4efc-b212-e3c970e15a0e

Copy link
Contributor

@carlosrcoelho carlosrcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@anovazzi1 anovazzi1 enabled auto-merge June 26, 2024 18:38
@anovazzi1 anovazzi1 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into dev with commit a471c67 Jun 26, 2024
13 of 14 checks passed
@anovazzi1 anovazzi1 deleted the fixFlowSettings branch June 26, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants