-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flow settings validation and save button #2360
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kinda as it was before, but with a wierder behavior. It doesn't matter if I change the description or the endpoint, it doesn't activate the save button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This pull request fixes the validation and save button behavior in the flow settings modal. Previously, the save button was not disabled when it should have been, and the endpoint name validation was not working correctly. This PR updates the validation logic and ensures that the save button is disabled when necessary.