Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows for better test coverage and integration #2344

Merged
merged 4 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/lint-py.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,20 @@ name: Lint Python

on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- "poetry.lock"
- "pyproject.toml"
- "src/backend/**"
- "tests/**"
merge_group:
branches: [dev]

types: [checks_requested]
env:
POETRY_VERSION: "1.8.2"

jobs:
lint:
name: Run Mypy
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -34,6 +35,8 @@ jobs:
run: |
poetry env use ${{ matrix.python-version }}
poetry install
- name: Run Mypy
run: |
make lint
env:
GITHUB_TOKEN: ${{ secrets.github_token }}
13 changes: 4 additions & 9 deletions .github/workflows/python_test.yml
Original file line number Diff line number Diff line change
@@ -1,26 +1,21 @@
name: Python tests

on:
push:
branches: [main]
paths:
- "poetry.lock"
- "pyproject.toml"
- "src/backend/**"
pull_request:
branches: [dev]
types: [opened, synchronize, reopened]
branches: [dev, main]
paths:
- "poetry.lock"
- "pyproject.toml"
- "src/backend/**"
merge_group:
branches: [dev]

types: [checks_requested]
env:
POETRY_VERSION: "1.8.2"

jobs:
build:
name: Run Unit Tests
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/typescript_test.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
name: Run Frontend Tests

on:
pull_request:
paths:
- "src/frontend/**"
workflow_dispatch:
inputs:
branch:
description: "Branch to run tests on"
required: true
type: string


env:
POETRY_VERSION: "1.8.2"
Expand All @@ -15,6 +19,7 @@ env:

jobs:
setup-and-test:
name: Run Frontend Tests on branch ${{ inputs.branch }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand All @@ -24,6 +29,8 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ inputs.branch }}

- name: Setup Node.js
uses: actions/setup-node@v4
Expand Down