fix: resolve Model Issues and add huggingface dependency #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
bug
ogabrielluiz
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Hey @berrytern
Thanks for the PR. Please review the comments.
| @@ -157,6 +148,8 @@ def build_model(self) -> LanguageModel: | |||
| f"Provider {self.provider} is not supported. Supported providers are: {', '.join(provider_map.keys())}" | |||
| ) | |||
|
|
|||
| os.environ["OPENAI_API_KEY"] = self.api_key | |||
There was a problem hiding this comment.
We shouldn't change the users environment.
| replicate_api_key=api_keys["replicate_api_key"], | ||
| cohere_api_key=api_keys["cohere_api_key"], | ||
| openrouter_api_key=api_keys["openrouter_api_key"], | ||
| openai_api_key=self.api_key, |
There was a problem hiding this comment.
Won't this pass the same variable to all? I assume only one api key must be passed, otherwise it will try to run the wrong one.
ogabrielluiz
force-pushed
the
dev
branch
2 times, most recently
from
299eaa5 to
4365e3d
Compare
dosubot
bot
added
size:L
ogabrielluiz
requested changes
Jun 25, 2024
|
|
||
| os.environ["OPENAI_API_KEY"] = self.api_key | ||
| api_keys: dict[str, Optional[str]] = {provider_map[self.provider]: self.api_key} | ||
| os.environ[self.provider.upper() + "_API_KEY"] = self.api_key |
There was a problem hiding this comment.
We shouldn't change the user's environment.
There was a problem hiding this comment.
Sorry about that. I fixed it in my last commit.
blucas-accela
approved these changes
Jun 27, 2024
ogabrielluiz
approved these changes
Jun 27, 2024
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
autofix.ci
ogabrielluiz
changed the title
|
Cannot auto-update because of conflicts. |
|
Cannot auto-update because of conflicts. |
- Change Huggingface-hub version from 0.20.0 to 0.22.0; - Internal model_id resolver not working, create a field to model_id;
dosubot
bot
added
size:M
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 2, 2024
…#2339) * chore: adding default values to Azure OpenAI mandatory component * fix: huggingface model component: - Change Huggingface-hub version from 0.20.0 to 0.22.0; - Internal model_id resolver not working, create a field to model_id; * feat: add HuggingFace as extra dependency * chore: remove redundant atribution on children * fix: remove user environment variables from ChatLiteLLMModelComponent --------- Co-authored-by: joaoguilhermeS <[email protected]> (cherry picked from commit 805df82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
model_idfield (auto resolution was broken);Refact: