Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci pr-checker enforce meaningful pr title and description #2232

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

zzzming
Copy link
Collaborator

@zzzming zzzming commented Jun 20, 2024

add a pr-checker ci job to make sure sufficient PR title and description are provided.

For the description, we can use a template. So this job so far just make sure it meets 25 characters.

Sufficient PR description is needed because the repo has enforced merge-squash that only one commit is merged to the dev branch after squashing all the commits under a PR. The history may get lost because of that therefore we enforce the sufficient PR title.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:04am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 20, 2024
@dosubot dosubot bot added the enhancement New feature or request label Jun 20, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 20, 2024
@ogabrielluiz ogabrielluiz merged commit 574f1d7 into dev Jun 20, 2024
9 checks passed
@ogabrielluiz ogabrielluiz deleted the pr-checker branch June 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants