Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Couchbase vector store #1901

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

prajwal-pai77
Copy link
Contributor

@prajwal-pai77 prajwal-pai77 commented May 15, 2024

This PR intends to add support for couchbase as a vector store for langflow.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 1:06pm

Copy link

@thelokeshgoel00 thelokeshgoel00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Comments, Please resolve them

@@ -86,6 +86,7 @@ langchain-google-vertexai = "^1.0.3"
langchain-groq = "^0.1.3"
langchain-pinecone = "^0.1.0"
langchain-mistralai = "^0.1.6"
couchbase = "^4.2.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, i think for python langchain it is 4.2.1?

@prajwal-pai77 prajwal-pai77 marked this pull request as ready for review May 22, 2024 11:23
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code python Pull requests that update Python code labels May 22, 2024
@@ -9,10 +9,12 @@
from .VectaraSearch import VectaraSearchComponent
from .WeaviateSearch import WeaviateSearchVectorStore
from .pgvectorSearch import PGVectorSearchComponent
from .Couchbase import CouchbaseSearchComponent # type: ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to handle this better? Ideally, you should not have to ignore this as the other imports don't

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error
src/backend/base/langflow/components/vectorsearch/init.py:12: error: Skipping analyzing "langflow.components.vectorsearch.Couchbase": module is installed, but missing library stubs or py.typed marker [import-untyped]

If i do not ignore the type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even other vectore stores have added this ignore in their respective files

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try moving the ignore into the Couchbase vector store like other providers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried moving it into the CouchbaseSearch.py and the error still persists.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this getting used or only Couchbase.jsx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed the format, similar to other vector stores which also contain the 3 files

@ogabrielluiz ogabrielluiz merged commit 19680bb into langflow-ai:dev May 23, 2024
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants