-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Couchbase vector store #1901
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Comments, Please resolve them
src/backend/base/langflow/components/vectorsearch/CouchbaseSearch.py
Outdated
Show resolved
Hide resolved
@@ -86,6 +86,7 @@ langchain-google-vertexai = "^1.0.3" | |||
langchain-groq = "^0.1.3" | |||
langchain-pinecone = "^0.1.0" | |||
langchain-mistralai = "^0.1.6" | |||
couchbase = "^4.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, i think for python langchain it is 4.2.1?
src/backend/base/langflow/components/vectorsearch/CouchbaseSearch.py
Outdated
Show resolved
Hide resolved
@@ -9,10 +9,12 @@ | |||
from .VectaraSearch import VectaraSearchComponent | |||
from .WeaviateSearch import WeaviateSearchVectorStore | |||
from .pgvectorSearch import PGVectorSearchComponent | |||
from .Couchbase import CouchbaseSearchComponent # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to handle this better? Ideally, you should not have to ignore this as the other imports don't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this error
src/backend/base/langflow/components/vectorsearch/init.py:12: error: Skipping analyzing "langflow.components.vectorsearch.Couchbase": module is installed, but missing library stubs or py.typed marker [import-untyped]
If i do not ignore the type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even other vectore stores have added this ignore in their respective files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try moving the ignore into the Couchbase vector store like other providers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried moving it into the CouchbaseSearch.py and the error still persists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this getting used or only Couchbase.jsx
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followed the format, similar to other vector stores which also contain the 3 files
This PR intends to add support for couchbase as a vector store for langflow.