Node modal #174
Merged
Node modal #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielluiz
requested changes
Apr 19, 2023
There was a problem hiding this comment.
The advanced condition defines if the field should be in the advanced popup, but show also does that, so, if advanced is true and show is true the field appears on both places.
Maybe we should just check if advanced or show is true since both seem to do the same thing.
…dNode classes Add an advanced flag to the TemplateFieldCreator and FrontendNode classes to allow for fields to be hidden from the user interface. In the TemplateFieldCreator class, the advanced flag is set to False by default. In the FrontendNode class, the advanced flag is set to False for all fields except for "model_type" and "model_kwargs", which are set to True.
|
Strongly disagree, 'advanced' should display in the modal and 'show' in the node. two different things. |
|
But what if we set both to True? I think right now One idea: what if we only show things that require another node (inputs), and all the rest go into the advanced part? |
…r class refactor(langflow): set advanced flag to False for LLMFrontendNode class' api key field feat(langflow): add show flag to LLMFrontendNode class' model_kwargs field refactor(langflow): set advanced flag to False and show flag to True for LLMFrontendNode class' model_name and temperature fields
feat(tests): add 'advanced' field to template properties in test files
… prompt in ChainFrontendNode class
ogabrielluiz
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to the flow editor that allows users to access advanced fields of a node in a modal pop-up window. The modal pop-up is triggered by clicking on a new button on the top-right corner of the node.
The pop-up window contains all of the advanced fields for the selected node, organized in an intuitive and easy-to-use interface. Users can enter and edit data in the pop-up window, and all changes are automatically reflected in the main flow editor.
This feature is particularly useful for complex flows with nodes that have many advanced fields, as it simplifies the user interface and makes it easier to manage and edit the flow. It also helps to prevent clutter on the main flow editor by hiding advanced fields until they are needed.