Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies frontend chatComponent to itemize validation errors #126

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

cayal
Copy link
Contributor

@cayal cayal commented Apr 6, 2023

Currently, if a user tries to submit a chat message, but there are nodes with validation errors, they get a message reading "Please fill in all the required fields before continuing", but no explanation as to what fields are missing.

The validateNodes check within chatComponent previously returned a boolean indicating whether any template fields have missing values.

This PR changes the return value to an array of "(node name) is missing (field name)." for any template fields with missing values. If the array has any length, it's considered to be invalid.

@ogabrielluiz
Copy link
Contributor

@anovazzi1 could you take a look at this one, please?

@anovazzi1
Copy link
Contributor

sure !

@anovazzi1 anovazzi1 merged commit 309c443 into langflow-ai:dev Apr 6, 2023
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change just some error messages, but everything is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants